Update database scripts to support MediaWiki 1.38 #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the test to reflect the two newly added tables (i.e., _linktarget, _mathlatexml) and the removed deprecated one (i.e., _wb_changes_dispatch).
m90
approved these changes
Mar 20, 2023
database/mw/docker-compose-clean.yml
Outdated
| volumes: | ||
| - ./maintWikWiki.json:/var/www/html/w/maintWikWiki.json | ||
| - ./:/usr/src/ |
There was a problem hiding this comment.
I wonder if this mount accidentally overwrites anything the image expects to be there?
Also, man hier advises against putting your own stuff in /usr/src:
/usr/src
Source files for different parts of the system, included with some packages for reference purposes. Don't work here with your own projects, as files below /usr should be read-only
except when installing software (optional).
Would it be a thing to just mount the php script in maintenance like this:
- ./cleanSql.php:/var/www/html/w/maintenance/cleanSql.php
There was a problem hiding this comment.
Good idea, thanks!
|
The DB dump seems good to me! https://www.diffchecker.com/mPYZnS3j/ |
deer-wmde
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.