Fix for websites with missing titles

wcember · Jun 6, 2016 · 9617f45 · 9617f45
1 parent 73d7b2a
commit 9617f45
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/pypub/chapter.py b/pypub/chapter.py
@@ -290,8 +290,11 @@ def create_chapter_from_string(self, html_string, url=None, title=None):
             try:
                 root = BeautifulSoup(html_string, 'html.parser')
                 title_node = root.title
-                title = unicode(title_node.string)
-            except IndexError:
+                if title_node is not None:
+                    title = unicode(title_node.string)
+                else:
+                    raise ValueError
+            except (IndexError, ValueError):
                 title = 'Ebook Chapter'
         return Chapter(clean_xhtml_string, title, url)
 

diff --git a/setup.py b/setup.py
@@ -2,7 +2,7 @@
 
 setup(
     name='pypub',
-    version='1.2',
+    version='1.3',
     packages=['pypub',],
     package_data={'pypub': ['epub_templates/*',]},
     author = 'William Cember',