Skip to content

Commit

Permalink
python3Packages.uvloop: disable test_write_to_closed_transport test o…
Browse files Browse the repository at this point in the history
…n 3.8+

Reenables the TCP testsuite and only disables the single failing test.

MagicStack/uvloop#355
  • Loading branch information
mweinelt authored and wchresta committed Aug 17, 2020
1 parent 9dfe935 commit d0e8c5d
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions pkgs/development/python-modules/uvloop/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
, libuv
, psutil
, isPy27
, pythonAtLeast
, CoreServices
, ApplicationServices
# Check Inputs
Expand Down Expand Up @@ -44,14 +45,11 @@ buildPythonPackage rec {
"--tb=native"
# ignore code linting tests
"--ignore=tests/test_sourcecode.py"
# Fails on Python 3.8
# https://salsa.debian.org/python-team/modules/uvloop/-/commit/302a7e8f5a2869e13d0550cd37e7a8f480e79869
"--ignore=tests/test_tcp.py"
];

disabledTests = [
"test_sock_cancel_add_reader_race" # asyncio version of test is supposed to be skipped but skip doesn't happen. uvloop version runs fine
];
] ++ lib.optionals (pythonAtLeast "3.8") [ "test_write_to_closed_transport" ]; # https://github.com/MagicStack/uvloop/issues/355

# force using installed/compiled uvloop vs source by moving tests to temp dir
preCheck = ''
Expand Down

0 comments on commit d0e8c5d

Please sign in to comment.