Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Generalize the FFT type #58

Closed
wdika opened this issue Apr 27, 2022 · 0 comments · Fixed by #66
Closed

Generalize the FFT type #58

wdika opened this issue Apr 27, 2022 · 0 comments · Fixed by #66
Assignees
@wdika
Labels
enhancement New feature or request

Comments

@wdika
Copy link
Owner

wdika commented Apr 27, 2022

Is your feature request related to a problem? Please describe.
The FFT type (for example here and here and here) can be defined multiple times and it is not always clear how normalization works.

Describe the solution you'd like
The fft_normalization and fft_dim should be leveraged better, to distinguish between several different options.
@wdika wdika added the enhancement New feature or request label Apr 27, 2022
@wdika wdika self-assigned this Apr 27, 2022
@wdika wdika linked a pull request May 29, 2022 that will close this issue
Addresses #57, #58, #60 #66
Merged
@wdika wdika closed this as completed in #66 May 29, 2022
wdika added a commit that referenced this issue May 29, 2022
@wdika
Addresses #57, #58, #60 (#66)
10943ce 
* mridc-60 Merge RSS for coil combination among inputs and targets

* mridc-58 Generalize the FFT type

* mridc-57 Define coil and spatial dimensions, instead of dataset type.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wdika wdika

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addresses #57, #58, #60 wdika/mridc
1 participant
@wdika