Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for regression issues and some improvements. #90

Merged
merged 10 commits into from
May 28, 2020

Conversation

hselasky
Copy link

Signed-off-by: Hans Petter Selasky hps@selasky.org

@miopa
Copy link

miopa commented May 28, 2020

No change, State is SMS and messages can't be received until module is unloaded and loaded again

@hselasky
Copy link
Author

Can you enable verbose messages in the cli for chan_dongle?

I basically need the sequence of AT commands being executed. Maybe there is an error communicating with the dongle.

--HPS

… incoming_sms.

Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
@hselasky hselasky force-pushed the master branch 2 times, most recently from 05e0f00 to 11df34d Compare May 28, 2020 14:53
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
@hselasky hselasky force-pushed the master branch 2 times, most recently from d67568a to a91275d Compare May 28, 2020 16:50
@hselasky hselasky changed the title Use incoming_sms_index field as indication of incoming SMS. Fixes for regression issues and some improvements. May 28, 2020
@hselasky
Copy link
Author

Please try again now.

Signed-off-by: Hans Petter Selasky <hps@selasky.org>
Signed-off-by: Hans Petter Selasky <hps@selasky.org>
@miopa
Copy link

miopa commented May 28, 2020

I have just checked-out your fork (at 5110695) and works properly.

(I also tested with applying the commits to wdoekes/master, confirming that sending and receiving simple and concatenated SMS is good)

@wdoekes
Copy link
Owner

wdoekes commented May 28, 2020

Awesome. All commits are looking sharp 👌

@wdoekes wdoekes merged commit 328b2b7 into wdoekes:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants