Feature/Add classes for desalination and extend network function #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyLiu0719
changed the title
* First skeleton of hello world docs * Working on JSON description * progress on documentation * WIP on docs' * Fixed typo in sample.json * Updated advanced.rst * More progress on docs * WIP on updating tests * Only a few tests still failing * All tests now passing * Finished hello.rst * Updated theme to sphinx-rtd-theme * First draft of docs is done * Passes flake8
* Changing name of network.units to network.num_units * Updated tests to account for name change * Fixed a couple corrupted pickle files * Fixed flake8 whitespace error * Reformatted with black
* Added charge rate and RTE attributes to battery * Added ContentsType for chemical dosing * Tweak to Speed units * Added hertz to unit processing * Removed units from capacity, charge, and discharge rate * Implemented FutureWarning for old syntax * Added backwards compatability with getters/setters * test_get_capacities completed * Created get_efficiencies function * Autoreformatted with black * Trying to fix getter and setter for backwards compatability * Fixed test_get_efficiencies * Still trying to figure out back compat * Forgot to import warnings, duh * Removed flake8 warnings * trying to break circular dependency * Typos in energy_capacity * Trying to avoid infinite recursion * Finally fixed the getter/setters * Fixed backwards compat with charge_rate * Typo in del_charge_rate * Added RTE getter/setter * Forgot getter/setter for leakage * Adding verbose flag * Missed variable assignment in parse_json * WIP updating flow rate logic * Reworked flow rate and pressure representation * fixed test_get_capacities * Typo in CAPACITY_ATTRS * Fixed to_json bug with capacities * Fixed line too long linter error * Extending tests to DeprecationWarnings * Fixed unused import linter error
|
Closing this as it will be handled in #89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request recommendations:
Thanks for contributing!
Change:
ModularUnit,StaticMixer,ROMembrane,UVSystem)parse_json.py, which allow networks incorporates subnetwork into a node in a existing network