This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Relax Postcode Validation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acleon
approved these changes
Oct 5, 2017
Removes the regex that only covers UK based postcodes as users are allowed to select a valid county optiona that is "outside of the UK". We could integrate with an external web service or introduce regexes that cover international addresses but this is overkill for a simple form.
rossey
force-pushed
the
fix/postcode-rule
branch
from
c0aafa2
to
badcfeb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the regex that only covers UK based postcodes as users are
allowed to select a valid county optiona that is "outside of the UK".
We could integrate with an external web service or introduce regexes
that cover international addresses but this is overkill for a simple
form.