Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API should not rely on Environment Variables #106

Closed
gaelph opened this issue Sep 7, 2021 · 1 comment
Closed

API should not rely on Environment Variables #106

gaelph opened this issue Sep 7, 2021 · 1 comment
Assignees
@gaelph

Comments

@gaelph
Copy link
Contributor

gaelph commented Sep 7, 2021

Currently the API uses environment variables for secrets, which implies that secret values are accessible in memory on the hosting machine. Those values should be in the compiled binary (using LDFLAGS, for instance)
@gaelph gaelph self-assigned this Sep 7, 2021
@gaelph
Copy link
Contributor Author

gaelph commented Sep 13, 2021

This has to be left on standby until all the redis/memory store work gets merged into master.

@gaelph gaelph closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaelph gaelph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaelph