Change https variable to nodeHttp/Remove deprecated 'sys'/comments & organization #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and commented requires
…s because it is deprecated, add util from node because that is the correct way to get inspect now, also cleanup requires
yocontra
pushed a commit
that referenced
this pull request
Jan 26, 2012
Change https variable to nodeHttp/Remove deprecated 'sys'/comments & organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable was named https but was requiring standard http lib. I see why you didn't name it http, which is fine, but I think naming it nodeHttp would be better for someone jumping into the code.
require 'sys' is deprecated and not used in the file.
reorganized requires and added some comments for cleanliness.