Merge pull request #1 from Bobface/missing-participant-fix

Fix missing participants
wearekickback · Mar 28, 2020 · 8dd7102 · 8dd7102
2 parents a66c23f + 0001cba
commit 8dd7102
Show file tree

Hide file tree

Showing 2 changed files with 95 additions and 2 deletions.
diff --git a/src/participants.js b/src/participants.js
@@ -20,10 +20,36 @@ export const calculateNumAttended = participants => participants.reduce((m, v) =
   return m + (attended ? 1 : 0)
 }, 0)
 
-export const calculateFinalizeMaps = participants => {
+export const calculateFinalizeMaps = (participants, overrideMissingValue) => {
+  if (!(overrideMissingValue === undefined ||
+    overrideMissingValue === PARTICIPANT_STATUS.SHOWED_UP ||
+    overrideMissingValue === PARTICIPANT_STATUS.REGISTERED)) {
+    throw new Error(`Invalid overrideMissingValue, expected undefined, SHOWED_UP or REGISTERED , got ${overrideMissingValue}`)
+  }
+
   // sort participants array
   participants.sort((a, b) => (a.index < b.index ? -1 : 1))
 
+  // check for missing participants
+  for (let i = 0; participants.length > i;) {
+    const currentIndex = participants[i].index
+    if (currentIndex !== i) {
+      if (overrideMissingValue === undefined) {
+        throw new Error(`Participant ${i} is missing`)
+      }
+
+      participants.splice(i, 0, {
+        overrideMissingValue,
+        index: i,
+        user: {
+          address: '0x0000000000000000000000000000000000000000'
+        },
+      })
+    } else {
+      i += 1
+    }
+  }
+
   const maps = []
   let currentMap = toBN(0)
   for (let i = 0; participants.length > i; i += 1) {
@@ -42,8 +68,8 @@ export const calculateFinalizeMaps = participants => {
         throw new Error(`Unexpected participant status: ${participants[i].status}`)
     }
   }
-  maps.push(currentMap)
 
+  maps.push(currentMap)
   return maps.map(m => m.toString(10))
 }
 

diff --git a/src/participants.test.js b/src/participants.test.js
@@ -211,6 +211,73 @@ describe('.calculateFinalizeMaps', () => {
 
     expect(calculateFinalizeMaps(ps)).toEqual(maps)
   })
+
+  it('p5 is missing, override REGISTERED', () => {
+    // We set #6 to SHOWED_UP and remove #5 from the list
+    const maps = [
+      toBN(0).bincn(6).toString(10),
+      toBN(0).toString(10),
+    ]
+
+    ps.forEach(p => {
+      switch (p.index) {
+        case 6:
+          p.status = PARTICIPANT_STATUS.SHOWED_UP
+          break
+        default:
+          break
+      }
+    })
+
+    ps.sort((a, b) => (a.index < b.index ? -1 : 1))
+    ps.splice(5, 1)
+
+    expect(calculateFinalizeMaps(ps, PARTICIPANT_STATUS.REGISTERED)).toEqual(maps)
+  })
+
+  it('p5 is missing, override SHOWED_UP', () => {
+    // We set #6 to SHOWED_UP and remove #5 from the list
+    const maps = [
+      toBN(0).bincn(6).bincn(5).toString(10),
+      toBN(0).toString(10),
+    ]
+
+    ps.forEach(p => {
+      switch (p.index) {
+        case 6:
+          p.status = PARTICIPANT_STATUS.SHOWED_UP
+          break
+        default:
+          break
+      }
+    })
+
+    ps.sort((a, b) => (a.index < b.index ? -1 : 1))
+    ps.splice(5, 1)
+
+    expect(calculateFinalizeMaps(ps, PARTICIPANT_STATUS.SHOWED_UP)).toEqual(maps)
+  })
+
+  it('p5 is missing, override default value', () => {
+    ps.forEach(p => {
+      switch (p.index) {
+        case 6:
+          p.status = PARTICIPANT_STATUS.SHOWED_UP
+          break
+        default:
+          break
+      }
+    })
+
+    ps.sort((a, b) => (a.index < b.index ? -1 : 1))
+    ps.splice(5, 1)
+
+    expect(() => calculateFinalizeMaps(ps)).toThrow()
+  })
+
+  it('override invalid value', () => {
+    expect(() => calculateFinalizeMaps(ps, 123)).toThrow()
+  })
 })