Fix missing participants #1
Conversation
src/participants.test.js
Outdated
| @@ -211,6 +211,30 @@ describe('.calculateFinalizeMaps', () => { | |||
|
|
|||
| expect(calculateFinalizeMaps(ps)).toEqual(maps) | |||
| }) | |||
|
|
|||
| it.only('p5 is missing, override', () => { | |||
There was a problem hiding this comment.
Please take out only to make sure that all the other tests pass
| ps.splice(5, 1) | ||
|
|
||
| expect(calculateFinalizeMaps(ps, true)).toEqual(maps) | ||
| }) |
There was a problem hiding this comment.
please add another test case which throws the Invalid overrideMissingValue error
src/participants.js
Outdated
| @@ -20,10 +20,36 @@ export const calculateNumAttended = participants => participants.reduce((m, v) = | |||
| return m + (attended ? 1 : 0) | |||
| }, 0) | |||
|
|
|||
| export const calculateFinalizeMaps = participants => { | |||
| export const calculateFinalizeMaps = (participants, overrideMissingValue = false) => { | |||
There was a problem hiding this comment.
I was thinking about the following 3 options
calculateFinalizeMaps(participants)= Default, raises error if there is a missing valuecalculateFinalizeMaps(participants, overrideMissingValue=1)= set missing value as 1calculateFinalizeMaps(participants, overrideMissingValue=0)= set missing value as 0calculateFinalizeMaps(participants, overrideMissingValue=12345)= invalid value, throw error
There was a problem hiding this comment.
Would be better to have the caller pass in the PARTICIPANT_STATUS.<value> as the overrideMissingValue.
There was a problem hiding this comment.
@hiddentao not sure about that. PARTICIPANT_STATUS has 5 valid statuses but this option has 3 (1, 0, null=throw error) and they don't map equally
There was a problem hiding this comment.
Just disallow the ones that don't map then.
There was a problem hiding this comment.
Otherwise, create a new enum to pass in as that would still be better than passing in magic numbers.
Fix missing participants
Adds checks for missing participants when calling calculating finalize maps.
The method
calculateFinalizeMapshas a new parameteroverrideMissingValuewhich defaults tofalse.overrideMissingValue == falsethe method throws an error when it detects a missing participant in theparticipantsarray.overrideMissingValue == truethe method inserts a dummy participant withstatus = PARTICIPANT_STATUS.REGISTEREDwhen it detects a missing participant