This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Indebanvdhamer/performance #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Danger run resulted in 2 warnings; to find out more, see the checks page. Generated by 🚫 dangerJS |
indebanvdhamer
force-pushed
the
indebanvdhamer/performance
branch
from
1377b35
to
2a47659
Compare
indebanvdhamer
requested review from
dicearr,
renanborgez,
Amri91 and
piotr-gawlowski
piotr-gawlowski
previously approved these changes
Aug 31, 2018
renanborgez
reviewed
Aug 31, 2018
| { | ||
| loader: 'sass-loader', | ||
| options: { | ||
| data: ` |
renanborgez
previously approved these changes
Aug 31, 2018
Amri91
reviewed
Aug 31, 2018
plugins/lodash.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| const LodashModuleReplacementPlugin = require('lodash-webpack-plugin'); | |||
There was a problem hiding this comment.
I am not sure how useful this file is.
Can we do
module.exports = require('lodash-webpack-plugin')?
There was a problem hiding this comment.
We could. I was just trying to keep consistent with the file structure of the other plugins. Let's discuss.
|
This is a breaking change, should be increase the version in the same merge to master? |
Amri91
previously approved these changes
Aug 31, 2018
Yes |
indebanvdhamer
dismissed stale reviews from Amri91, dicearr, renanborgez, and piotr-gawlowski
via
d6814b2
indebanvdhamer
force-pushed
the
indebanvdhamer/performance
branch
from
2a47659
to
d6814b2
Compare
indebanvdhamer
force-pushed
the
indebanvdhamer/performance
branch
from
21cfe6c
to
9e6235e
Compare
Amri91
approved these changes
Aug 31, 2018
renanborgez
approved these changes
Aug 31, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Webpack has pretty bad performance when it comes to the
scss-loader. This PR improves performance by removing some of the default options, since they're not always needed. They can still be passed via the.webpacker.jsfile.Changes
postcss-preset-env.