Increase minimum PHP version to 7.0

[grappler]

Currently we have <config name="testVersion" value="5.6-"/>. I would like to increase the default to 7.0. I would prefer to set it down 5.6 as the exception.

If all are agreed I can create a PR.

[swissspidy]

Or even 7.1 or 7.2?

[grappler]

Actually I could not find a way to override the testVersion so it may be best to define it on a package level.

I think 7.1 should be good for most projects with the plan to move to 7.2. wearerequired.local is still running on PHP 7.1 due to Kaufleuten.

[swissspidy]

Actually I could not find a way to override the testVersion so it may be best to define it on a package level.

Do you mean the current definition is not working? Or changing it isn't possible in this ruleset here? Then why should it work in another package? 🤔

We should set the testVersion here in the coding standards package, not in each and every project of ours.

[grappler]

For different projects we may have different minimum PHP requirements due to Libraries that we use.

We could only update the minimum version only once all of our projects are compatible with the next version.

If we set the minimum to 7.1 we should be mostly good. If we went for 7.0 then in some of our plugins there will be warnings for using code that is not 7.0 compatible.

[swissspidy]

When we set it to 7.0 here we can simply set it to 7.1 in a plugin that requires that, no?

[grappler]

When we set it to 7.0 here we can simply set it to 7.1 in a plugin that requires that, no?

No, not that I could work out. That is what I was trying to say #23 (comment)

[grappler]

@ocean90 What do you think? Need a third opinion.

[ocean90]

Why is it not possible to override this value per project? Sound like a bug which should get reported upstream.

[grappler]

I have created an issue for this squizlabs/PHP_CodeSniffer#2197

[ocean90]

@grappler Feel free to bump it to 7.0. Projects which still require 5.6 probably don't even use this ruleset.

[ocean90]

In 7d0dbb9 I actually went ahead and bumped it to 7.1 since that's the version most of our projects is using. By end of the year we should bump it to 7.2, see http://php.net/supported-versions.php.

[ocean90]

The upstream issue was closed a few days ago. With 4.0.0 a project config should be able to override the default config.