Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to select the headline level for headline type #3

Closed
ocean90 opened this issue Oct 18, 2018 · 2 comments
Closed

Allow to select the headline level for headline type #3

ocean90 opened this issue Oct 18, 2018 · 2 comments
Assignees
@ocean90
Labels
enhancement
Milestone
2.0

Comments

@ocean90
Copy link
Member

ocean90 commented Oct 18, 2018

It's currently h4 by default.

custom-menu-item-types/classes/Custom_Menu_Items.php

Line 86 in eeb0e30

$item_output = '<h4>' . $item->post_title . '</h4>';

@ocean90 ocean90 self-assigned this Oct 18, 2018
@ocean90 ocean90 added this to the 2.0 milestone Oct 18, 2018
ocean90 added a commit that referenced this issue Oct 18, 2018
@ocean90
Make nav_menu_item_fields() more readable.
8a5cb61 
See #3
@grappler
Copy link
Contributor

grappler commented Oct 19, 2018 •
edited
Loading

I think we should add a headline level option to the other menu items too that have a header. See #16

@grappler grappler mentioned this issue Oct 19, 2018
Closed
2 tasks
@grappler
Copy link
Contributor

I feel that the heading dropdown should come before the custom class field.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocean90 ocean90

Labels
enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@ocean90 @grappler