Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint tasks are getting added under wrong workflow #401

Closed
cseas opened this issue Feb 24, 2022 · 3 comments
Closed

Lint tasks are getting added under wrong workflow #401

cseas opened this issue Feb 24, 2022 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@cseas
Copy link

cseas commented Feb 24, 2022

Opening #35 again because I'm experiencing the same behaviour.

lint-action is added under my ci workflow but the ESLint and Prettier checks are getting added under a different workflow that I have.

Screenshot 2022-02-24 at 1 59 44 PM

Does lint-action add all new checks to the first workflow by default?

@cseas
Copy link
Author

cseas commented Feb 24, 2022

Had to work around the problem by creating a separate workflow file for this action. But that seems redundant since now I need to setup and install node modules in two different workflows. Earlier one workflow was enough to do all CI related checks.

Screenshot 2022-02-24 at 2 18 59 PM

@cseas
Copy link
Author

cseas commented Feb 24, 2022

Doesn't look like even that fixed it. The action is definitely adding new checks to the first workflow, whichever one it is. Another run gave this result:

Screenshot 2022-02-24 at 2 42 40 PM

@ocean90 ocean90 added the duplicate This issue or pull request already exists label Mar 8, 2022
@ocean90
Copy link
Member

ocean90 commented Mar 8, 2022

Hi there, this is an issue with how the GitHub checks API works. Checks are attached to commit SHAs and the annotations are added to latest workflow run for the commit being tested. This is nothing this action can fix.

Related report: https://github.community/t/github-actions-status-checks-created-on-incorrect-check-suite-id/16685

Duplicate of #280, #97, #93.

@ocean90 ocean90 closed this as completed Mar 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants