Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks on NPM 10.6.0 #789

Closed
broksonic21 opened this issue Apr 25, 2024 · 3 comments
Closed

Breaks on NPM 10.6.0 #789

broksonic21 opened this issue Apr 25, 2024 · 3 comments

Comments

@broksonic21
Copy link

broksonic21 commented Apr 25, 2024

NPM 10.6.0 changed how it logs out when running npx commands, and the eslit parser for wearerequired/lint-action isn't handling it

NPM 10.5.2:

~/git/personal/shared-configs (main ✔) npx eslint --ext .js --fix --no-color --format json .
[{"filePath":"/Users/REDACTED/REDACTED/personal/shared-configs/.eslintrc.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]},{"filePath":"/Users/REDACTED/REDACTED/personal/shared-configs/packages/eslint-config/index.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]},{"filePath":"/Users/REDACTED/REDACTED/personal/shared-configs/packages/stylelint-config/index.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]}]

NPM 10.6.0:

~/git/personal/shared-configs (renovatebot/node_npm ✔) npx eslint --ext .js --fix --no-color --format json .

> @REDACTED/shared-configs@7.10.2 npx
> eslint --ext .js --fix --no-color --format json .

[{"filePath":"/Users/REDACTED/REDACTED/personal/shared-configs/.eslintrc.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]},{"filePath":"/Users/REDACTED/REDACTED/personal/shared-configs/packages/eslint-config/index.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]},{"filePath":"/Users/REDACTED/REDACTED/personal/shared-configs/packages/stylelint-config/index.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]}]

Notice the lines at here that showed up.

> @REDACTED/shared-configs@7.10.2 npx
> eslint --ext .js --fix --no-color --format json .

This causes issues in the lint parser for this action.

Logs:

Run ESLint
  Verifying setup for ESLint…
  Verified ESLint setup
  Will use ESLint to check the files with extensions js
  Linting and auto-fixing files in /home/runner/work/shared-configs/shared-configs with ESLint …
  Error: Error parsing ESLint JSON output: Unexpected token > in JSON at position 0. Output: "> @REDACTED/shared-configs@7.10.2 npx
  > eslint --ext .js --fix --no-color --format json .
  
  [{"filePath":"/home/runner/work/shared-configs/shared-configs/.eslintrc.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]},{"filePath":"/home/runner/work/shared-configs/shared-configs/packages/eslint-config/index.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]},{"filePath":"/home/runner/work/shared-configs/shared-configs/packages/stylelint-config/index.js","messages":[],"suppressedMessages":[],"errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":[{"ruleId":"dot-location","replacedBy":[]},{"ruleId":"new-parens","replacedBy":[]},{"ruleId":"no-mixed-operators","replacedBy":[]},{"ruleId":"no-new-object","replacedBy":["no-object-constructor"]},{"ruleId":"no-whitespace-before-property","replacedBy":[]},{"ruleId":"rest-spread-spacing","replacedBy":[]},{"ruleId":"padding-line-between-statements","replacedBy":[]}]}]"
@broksonic21
Copy link
Author

Filed vs npm 10.6.0 as well: npm/cli#7419

@broksonic21
Copy link
Author

NPM is fixing this, so you can probably ignore it.

@broksonic21
Copy link
Author

Closing- npm fixed this in npm 10.7.0, which makes it work with this github action now.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant