Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NPM 10.6.0 outputs new lines when running npx #7419

Closed
2 tasks done
broksonic21 opened this issue Apr 25, 2024 · 5 comments · Fixed by #7421
Closed
2 tasks done

[BUG] NPM 10.6.0 outputs new lines when running npx #7419

broksonic21 opened this issue Apr 25, 2024 · 5 comments · Fixed by #7421
Assignees
Labels
Bug thing that needs fixing Priority 0 will get attention right away Release 10.x

Comments

@broksonic21
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

With NPM 10.5.2, logs are clear when running npx:

~/git/personal/test (main ✔) npx eslint

but with 10.6.0, there's new logging that shows up - this breaks tools looking for outputted strings in the results, as it's unexpected. I'm seeing this break some github actions expecting results from commands too: see wearerequired/lint-action#789

It's happening with any and all npx commands

~/git/personal/test (main ✔) npx eslint

> REDACTED@0.1.0 npx
> eslint

Expected Behavior

No unexpected logs being written out

Steps To Reproduce

Using npm 10.5.2
run any command with npx - don't get the logs

Using npm 10.6.0
run any command with npx - get the log lines

Environment

  • npm: 10.6.0
  • Node.js: 20.12.2
  • OS Name: Mac
  • System Model Name: MacBook Pro

Note: also seeing on Ubuntu on Github Actions

@broksonic21 broksonic21 added Bug thing that needs fixing Needs Triage needs review for next steps Release 10.x labels Apr 25, 2024
@wraithgar wraithgar added Priority 0 will get attention right away and removed Needs Triage needs review for next steps labels Apr 25, 2024
@wraithgar
Copy link
Member

Looks like we missed a spot on banner suppression.

@wraithgar
Copy link
Member

explore also was setting banner: false

@wraithgar
Copy link
Member

Thanks for testing the latest npm so quickly @broksonic21. npm@10.6.0 was a complete overhaul of the display layer. We thought we got everything but obviously missed this one.

@broksonic21
Copy link
Author

Thanks for quick response/getting a fix in action. It broke our CI when renovatebot prompted me to update (see wearerequired/lint-action#789) so was nice and quick.

@lukekarrys
Copy link
Contributor

I made #7421 to fix this. This likely won't have to wait for our typical (bi-)weekly release cycle. I think we should put out a quick patch for this a few others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 0 will get attention right away Release 10.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants