Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pull_request events #9

Closed
SimenB opened this issue Jan 5, 2020 · 5 comments
Closed

Add support for pull_request events #9

SimenB opened this issue Jan 5, 2020 · 5 comments
Assignees
@samuelmeuli
Labels
enhancement New feature or request

Comments

@SimenB
Copy link

SimenB commented Jan 5, 2020 •
edited

Probably something I messed up...

image

Both eslint and prettier says they found an error, but the step didn't fail and no annotation was added.

From jestjs/jest#9367
@samuelmeuli
Copy link
Collaborator

The problem is that the action is executed on the pull_request event, which it doesn't support yet (only the push event, which lets the action easily determine which commit needs to be annotated).

I'm planning to fix this though :)

@samuelmeuli samuelmeuli added the enhancement New feature or request label Jan 6, 2020
@samuelmeuli samuelmeuli changed the title Doesn't fail or provide annotations Not working with pull_request event Jan 6, 2020
@SimenB
Copy link
Author

SimenB commented Jan 6, 2020

Ah, that makes sense. It should fail the step regardless though, no? Or maybe just explode if ran on an unsupported event altogether

@samuelmeuli
Copy link
Collaborator

Or maybe just explode if ran on an unsupported event altogether

Yeah, I expected this to be the current behavior, but it looks like I removed the check at some point 😅 I'll add it back as a temporary solution and will think about how the pull_request event could be supported.

samuelmeuli added a commit that referenced this issue Jan 6, 2020
@samuelmeuli
Exit if not called on "push" event
fd5ea01 
Temporary solution for #9
@samuelmeuli samuelmeuli changed the title Not working with pull_request event Add support for pull_request event Jan 7, 2020
@samuelmeuli samuelmeuli self-assigned this Jan 7, 2020
@samuelmeuli samuelmeuli changed the title Add support for pull_request event Add support for pull_request events Jan 7, 2020
@samuelmeuli
Copy link
Collaborator

Released in v0.6.0

@SimenB
Copy link
Author

SimenB commented Jan 7, 2020

Oh, that was quick! Thanks 🎉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@samuelmeuli samuelmeuli

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimenB @samuelmeuli