Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter stdout/stderr assertions #16

Merged
merged 7 commits into from
Feb 9, 2020

Conversation

ascandella
Copy link
Contributor

I noticed while working on a new linter that my test was passing even though the stdout/stderr was incorrect.

This seems to be fallout from this refactor:
73e9574

I had to update the timezone date regex to allow my timezone as well.

I also updated the gofmt linter, since it sends its output to stdout. I also fixed the tests for it.

I updated the prettier test to remove the fix assertion on stdout because, on my machine, it outputs something like:

    Expected: ""
    Received: ".prettierrc.json 26ms
    file1.js 18ms
    file2.css 45ms
    package.json 6ms"

to stdout.

It looks like these were incorrectly ported in

wearerequired@73e9574

So the test suite (before this commit) wasn't actually asserting
anything about the output.
@ascandella
Copy link
Contributor Author

The linter check doesn't seem to be checking out my branch properly (since it's on my fork, not on this repo):

  stderr: "error: pathspec 'fix-assertions' did not match any file(s) known to git\n"

Copy link
Collaborator

@samuelmeuli samuelmeuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks so much for these fixes @ascandella!

@samuelmeuli
Copy link
Collaborator

The "Lint" workflow is currently failing because of #13, that's not an issue with your code :)

@samuelmeuli samuelmeuli added the bug Something isn't working label Feb 9, 2020
@samuelmeuli samuelmeuli changed the title Fix linter stdout/stderr assertions in the test suite Fix linter stdout/stderr assertions Feb 9, 2020
@samuelmeuli samuelmeuli merged commit a421b0e into wearerequired:master Feb 9, 2020
@samuelmeuli
Copy link
Collaborator

Thanks!

@ascandella ascandella deleted the fix-assertions branch February 9, 2020 16:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants