Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot find declaration file issue #103

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

ColniIIIko
Copy link
Contributor

@ColniIIIko ColniIIIko commented Feb 29, 2024

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Description

Fix #93

🧡 Thank you!

@danestves danestves merged commit b97a80f into weareseeed:main Mar 7, 2024
9 checks passed
@samesfahani-tuplehealth

I could be wrong -- but this solution felt incomplete. It is using one typing file while trying to serve cjs and mjs.

See:

https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/FalseCJS.md#common-causes
https://arethetypeswrong.github.io/?p=react-square-web-payments-sdk%403.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not find a declaration file for module
3 participants