-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boot-environ does not update environment in pods #46
Comments
Make it a |
Ok, I'll put together a pull request. |
I've responded to all of the comments on the PR and tested the code again. Please take another look and see if there's anything else amiss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current
boot-environ
task updates the internal var containing the environment and passes this on to subsequent tasks. However, this does not work for tasks that create their own pods (such as theboot-test
task) because modified objects are not passed into pods when they are initialized. This makes testing code which usesenviron
for configuration difficult (or at least non-intuitive). If the task were to manage a.lein-env
file in the fileset in parallel with changes to the var, then the task should work identically for all tasks and make the task more useful.I have a modified task which does this and can make a pull request if you agree with the suggested change.
The text was updated successfully, but these errors were encountered: