Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest core.async version #12

Closed
wants to merge 2 commits into from

Conversation

fredZen
Copy link

@fredZen fredZen commented Feb 21, 2016

The core.async page seems to imply that 1.6.0 is the minimum clojure version
required, so I'm upgrading just to be on the safe side, although the tests do
pass with clojure 1.5.1.
Surprisingly, no upgrade to clojurescript seems to be necessary.

@fredZen
Copy link
Author

fredZen commented Feb 21, 2016

I can see that some tests fail on travis https://travis-ci.org/weavejester/reagi/jobs/110781443

I suspect there's something non deterministic about them (but maybe it's deterministic and just related to a precise version of the jdk). I will have a look into it but it might take some time.

@fredZen
Copy link
Author

fredZen commented Feb 21, 2016

I'm pretty confident now that the test failures were not caused by the changes I introduced.

This failure is caused by a fairly straightforward race condition in the test (issue #13 - unfortunately I don't see a straightforward fix). It also happened in https://travis-ci.org/weavejester/reagi/jobs/28763280 and https://travis-ci.org/weavejester/reagi/jobs/28763279 , which were caused by simple changes to documentation.

FAIL in (test-join) (core_test.clj:466)
once
expected: (realized? j)
  actual: (not (realized? #<Events@2660a55c: 3>))

This failure is less obvious. GC's aren't very deterministic, but that's hand waving, not an explanation. However, I also saw this failure in https://travis-ci.org/weavejester/reagi/jobs/79782535 , which was caused by simple changes to documentation.

FAIL in (test-gc) (core_test.clj:385)
GC unreferenced streams
expected: (nil? (clojure.core/deref a))
  actual: (not (nil? 1))

@fredZen fredZen mentioned this pull request Feb 21, 2016
@weavejester
Copy link
Owner

Yeah, I had forgotten but sometimes the tests aren't the most reliable, due to the library's asynchronous nature.

@weavejester
Copy link
Owner

This seems fine. Can you cut down the commit message to something like:

Update core.async dependency

@fredZen fredZen force-pushed the update-core-async branch 3 times, most recently from 024cf53 to b94329a Compare March 4, 2016 19:22
The core.async page seems to imply that 1.6.0 is the minimum clojure version
required, so I'm upgrading just to be on the safe side, although the tests do
pass with clojure 1.5.1.
Surprisingly, no upgrade to clojurescript seems to be necessary.
@fredZen fredZen closed this Sep 12, 2018
@fredZen fredZen deleted the update-core-async branch September 12, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants