Update to cljc #14
Closed
Update to cljc #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,8 +80,9 @@ | |||
|
|
|||
| (def time | |||
| "A behavior that tracks the current time in seconds." | |||
| #+clj (behavior (/ (System/nanoTime) 1000000000.0)) | |||
| #+cljs (behavior (/ (.getTime (js/Date.)) 1000.0))) | |||
| #?( | |||
There was a problem hiding this comment.
Can you remove the blank line here?
fredZen
force-pushed
the
update-to-cljc
branch
4 times, most recently
from
0ef68b7
to
860b3ec
Compare
|
Note: I found out that all the cljc compatible versions of clojurescript are incompatible with java 6. Is this a problem? I checked back as far as clojurescript 0.0-3196 (the version that introduced reader conditionals), and that version already had the lookahead regex that trips up the regex engine in java 6. |
fredZen
force-pushed
the
update-to-cljc
branch
2 times, most recently
from
4c3f68a
to
268e66b
Compare
The core.async page seems to imply that 1.6.0 is the minimum clojure version required, so I'm upgrading just to be on the safe side, although the tests do pass with clojure 1.5.1. Surprisingly, no upgrade to clojurescript seems to be necessary.
This forces upgrades to lein-cljsbuild and austin Also, with the update to lein-cljsbuild, :whitespace doesn't seem to be the default optimization anymore so I set it manually.
This forces to upgrade to a newer version of codox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon pull-request #12
The goal is to switch from the obsolete cljx to the newer cljc.
In order to do this, I had to upgrade Clojure and ClojureScript.
In turn, in order to upgrade ClojureScript, I had to upgrade lein-cljsbjuild and austin.
Finally, I updated codox to a version that is able to handle cljc.