Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
version
subcommand without any flags prints out a general versioninformation, good to check what version we have.
The
version
subcommand with--short
flag prints out only theversion, useful for scripting.
The
version
subcommand with--long
flag prints out a detailed versioninformation, useful for bug reports.
== Why a subcommand and not a
-v
or-V
flag?Because it can be confusing. Some applications are using
-v
forversion, some are using
-V
for version because-v
is the verboseflag. Go, kubectl, and Helm follows the same logic, they have a
version
subcommand.Different flags
version
subcommands all the time when I want to automate something, that's the
--short
.filing bug reports, that's the
--long
flag.the binary was renamed I can see what is the name of the application,
but without extra information like commit hash or build date. That's
the no-flag option.
Moved the log.Info call
In general, it's useful to print out the info log on
run
andgw
, butnot for
version
.Which issue(s) this PR fixes:
Fixes #163
Special notes for your reviewer:
Checklist: