Terraform 0.12.0 lint #177
Conversation
|
https://github.com/FiloSottile/gvt is archived: if someone more familiar with Go than I would kindly TAL, hopefully we can get these tests passing. It seems this repo is used in a lot of places! 🙂 |
unrecognized import path "io/fs": import path does not begin with hostname Signed-off-by: Kingdon Barrett <kingdon@weave.works>
It looks like this can be safely removed Signed-off-by: Kingdon Barrett <kingdon@weave.works>
from within build container that failed, the error message said: \# make go get -tags netgo ./. go: cannot find main module, but found .git/config in /go/src to create a module there, run: cd .. && go mod init Makefile:6: recipe for target 'cover' failed make: *** [cover] Error 1 Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
add 'go get -tags netgo \
github.com/FiloSottile/gvt \
github.com/client9/misspell/cmd/misspell \
github.com/fzipp/gocyclo \
github.com/gogo/protobuf/gogoproto \
github.com/gogo/protobuf/protoc-gen-gogoslick \
golang.org/x/lint/golint \
github.com/golang/protobuf/protoc-gen-go \
github.com/kisielk/errcheck \
github.com/mjibson/esc'
from build/golang/Dockerfile
(next commit probably ought to remove it from in there, where it is
likely wasted repeating the work)
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
$ docker run --rm -v "$PWD:/go/src" -w "/go/src" --entrypoint sh weaveworks /build-golang -c "./lint" go: downloading golang.org/x/tools v0.1.5 runner/runner.go:17:2: no required module provides package github.com/mgutz/ansi; to add it: go get github.com/mgutz/ansi runner/runner.go:18:2: no required module provides package github.com/weaveworks/common/mflag; to add it: go get github.com/weaveworks/common/mflag socks/main.go:12:2: no required module provides package github.com/armon/go-socks5; to add it: go get github.com/armon/go-socks5 socks/main.go:13:2: no required module provides package github.com/weaveworks/common/mflag; to add it: go get github.com/weaveworks/common/mflag socks/main.go:14:2: no required module provides package github.com/weaveworks/common/mflagext; to add it: go get github.com/weaveworks/common/mflagext Signed-off-by: Kingdon Barrett <kingdon@weave.works>
|
In this commit I added a I think we need someone to take a quick look who knows about go mod migration (but at least I got the build working again) |
|
Thanks. If someone who knows anything about the release cycle of this package is comfortable merging this, I definitely won't stop you. The build is green at least, if there are issues to follow up they can be handled in a separate PR. @morancj Back in your court? |
Updates for #176 via weaveworks/weave#3913 and weaveworks/weave#3914