Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 0.12.0 lint #177

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Terraform 0.12.0 lint #177

wants to merge 11 commits into from

Commits on Aug 31, 2021

  1. Syntax fixed for Terraform 0.12, pin provider versions

    @morancj
    morancj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    6335723 View commit details
    Browse the repository at this point in the history

  2. Add connection.host = self IPv4 address

    @morancj
    morancj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    4e7f46c View commit details
    Browse the repository at this point in the history

  3. terraform fmt -recursive

    @morancj
    morancj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    1b702f2 View commit details
    Browse the repository at this point in the history

  4. Terraform 0.12 outputs.tf

    @morancj
    morancj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    3158e36 View commit details
    Browse the repository at this point in the history

  5. Remote extra newline

    @morancj
    morancj committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    a451855 View commit details
    Browse the repository at this point in the history

  6. try upgrade golang to fix CI failure 

    unrecognized import path "io/fs": import path does not begin with hostname

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
    Kingdon Barrett committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    eccd0a7 View commit details
    Browse the repository at this point in the history

  7. go 'dep' is obsolete by go modules 

    It looks like this can be safely removed

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
    Kingdon Barrett committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    7164c66 View commit details
    Browse the repository at this point in the history

  8. go mod init github.com/weaveworks/build-tools 

    from within build container that failed, the error message said:

\# make
go get -tags netgo ./.
go: cannot find main module, but found .git/config in /go/src
	to create a module there, run:
	cd .. && go mod init
Makefile:6: recipe for target 'cover' failed
make: *** [cover] Error 1

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
    Kingdon Barrett committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    7b9e953 View commit details
    Browse the repository at this point in the history

  9. indentation change to satisfy the linter 

    Signed-off-by: Kingdon Barrett <kingdon@weave.works>
    Kingdon Barrett committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    173949e View commit details
    Browse the repository at this point in the history

  10. add tracking for go modules 

    add 'go get -tags netgo \

                github.com/FiloSottile/gvt \
                github.com/client9/misspell/cmd/misspell \
                github.com/fzipp/gocyclo \
                github.com/gogo/protobuf/gogoproto \
                github.com/gogo/protobuf/protoc-gen-gogoslick \
                golang.org/x/lint/golint \
                github.com/golang/protobuf/protoc-gen-go \
                github.com/kisielk/errcheck \
                github.com/mjibson/esc'
from build/golang/Dockerfile

(next commit probably ought to remove it from in there, where it is
likely wasted repeating the work)

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
    Kingdon Barrett committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    9cc4ff7 View commit details
    Browse the repository at this point in the history

  11. Add more modules to satisfy build environment 

    $ docker run --rm -v "$PWD:/go/src" -w "/go/src" --entrypoint sh weaveworks
/build-golang -c "./lint"
go: downloading golang.org/x/tools v0.1.5
runner/runner.go:17:2: no required module provides package github.com/mgutz/ansi; to add it:
	go get github.com/mgutz/ansi
runner/runner.go:18:2: no required module provides package github.com/weaveworks/common/mflag; to add it:
	go get github.com/weaveworks/common/mflag
socks/main.go:12:2: no required module provides package github.com/armon/go-socks5; to add it:
	go get github.com/armon/go-socks5
socks/main.go:13:2: no required module provides package github.com/weaveworks/common/mflag; to add it:
	go get github.com/weaveworks/common/mflag
socks/main.go:14:2: no required module provides package github.com/weaveworks/common/mflagext; to add it:
	go get github.com/weaveworks/common/mflagext

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
    Kingdon Barrett committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    32e44a1 View commit details
    Browse the repository at this point in the history