Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose demo/podinfo via the ALB Ingress controller #18

Closed
marccarre opened this issue Aug 30, 2019 · 1 comment · Fixed by #26
Closed

Expose demo/podinfo via the ALB Ingress controller #18

marccarre opened this issue Aug 30, 2019 · 1 comment · Fixed by #26
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@marccarre
Copy link
Contributor

marccarre commented Aug 30, 2019

eks-quickstart-app-dev currently creates an ALB Ingress controller, but we do not do anything with it, and it isn't trivial for the end-user how to leverage it. We should add an Ingress resource for at least demo/podinfo -- given this is our "demo" app of choice -- in order to (1) prove that ingress works, and (2) show end-users how to leverage the ALB in their cluster, to expose services.

@marccarre podinfo can be safely exposed outside the cluster to demo how the ingress works. The podinfo chart comes with ingress, I would enable it in the HelmRelease file.

Here is an example https://github.com/stefanprodan/gitops-helm-workshop/blob/master/cluster/releases/podinfo.yaml#L23

Originally posted by @stefanprodan

@marccarre marccarre added this to the 0.5.0 milestone Aug 30, 2019
@marccarre marccarre self-assigned this Sep 3, 2019
@gemagomez gemagomez added the documentation Improvements or additions to documentation label Sep 5, 2019
@gemagomez gemagomez modified the milestones: 0.5.0, 0.6.0 Sep 5, 2019
@marccarre
Copy link
Contributor Author

In the end, it was decided we wouldn't expose anything publicly for now, for security reasons.
This issue therefore now becomes a documentation issue.

marccarre added a commit that referenced this issue Sep 6, 2019
README.md: document port-forward and ingress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants