Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .wksctlignore file #32

Closed
wants to merge 1 commit into from
Closed

add .wksctlignore file #32

wants to merge 1 commit into from

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Oct 9, 2019

add a blank .wksctlignore file to tell wksctl that it must ignores files from this directory when doing wksctl profile enable.

add a blank .wksctlignore file to tell wksctl that it must ignores files from this directory when doing `wksctl profile enable`.
@chanwit
Copy link
Member Author

chanwit commented Oct 9, 2019

kindly ping @stefanprodan @palemtnrider @mflendrich
is it ok to implement this idea?

@palemtnrider
Copy link

Hi @chanwit I don't see where weaveworks/wksctl might be checking for this file. Is that going to be added later?

@chanwit chanwit changed the title add a blank .wksctlignore file add .wksctlignore file Oct 25, 2019
@chanwit
Copy link
Member Author

chanwit commented Oct 25, 2019

@palemtnrider I'm working on it. Feedback from @stefanprodan that I should use something similar to .gitignore.

@chanwit
Copy link
Member Author

chanwit commented Oct 25, 2019

Here's the implementation to recognize .wksctlignore in wksctl profile enable.

weaveworks/wksctl#104

@martina-if
Copy link
Contributor

@chanwit Sorry for the very late reply, we haven't been watching this repo.

I think this repo doesn't know anything about wksctl so it doesn't make sense to add a file here for that. Instead that file should be created by wks or other tooling that may connect them.

@martina-if martina-if closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants