-
Notifications
You must be signed in to change notification settings - Fork 55
implement file ignore in the profile enable process #104
Conversation
6fd56e3
to
2067257
Compare
cc @palemtnrider |
AppDevRepoURL = "git@github.com:weaveworks/eks-quickstart-app-dev" | ||
AppDevAlias = "app-dev" | ||
AppDevRepoURL = "git@github.com:weaveworks/eks-quickstart-app-dev" | ||
WKSctlIgnoreFilename = ".wksctlignore" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels to me that wksctl
in wksctlignore
refers to our tool in an overly specific way. It is not impossible that we have another tool (other than wksctl
) in the future that deals with profiles, for example.
Unless we're already committed to calling this .wksctlignore
, I suggest renaming to .profileignore
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mflendrich basically yes, it is very specific to wksctl
. Let me explain by referring to this example profile:
https://github.com/chanwit/eks-quickstart-app-dev
In the above profile, there are two ignore files .eksctlignore
and .wksctlignore
.
Each of them contains a set of file needs to be removed by each tool.
This is by design to make a single profile repo works on both eksctl
and wksctl
.
Thinking of this as a situation that we have .circleci
, .travis.yaml
and .drone.yaml
files on a git repo to allow each CI to independently process our repo (in its own way).
868d20b
to
678de73
Compare
678de73
to
042256e
Compare
042256e
to
7b9e447
Compare
34a4b95
to
7b9e447
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and clean PR, code LGTM! 👍
7b9e447
to
6d0d192
Compare
Thank you @mflendrich and @fbarl for your kindly reviews! |
implement file ignore in the profile enable process
This PR makes the
profile enable
command to uses contents of the.wksctlignore
file, if exists on the top most directory of the profile, to filter out unneeded files.What does this PR do:
.wksctlignore
at the top level directory of the profile..wksctlignore
file to dogit rm
.git subtree add
)A test case to test the processing of
.wksctlignore
is included.