Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all display options in the Logs panel #410

Merged

Conversation

Puneeth-n
Copy link
Contributor

@Puneeth-n Puneeth-n commented Oct 12, 2021

What does this do?

This PR adds the missing attributes to the Logs panel

Why is it a good idea?

It is not fully possible to set all attributes that is available in the Grafana UI
https://grafana.com/docs/grafana/latest/visualizations/logs-panel/#display-options

Context

Questions

@Puneeth-n Puneeth-n changed the title Add more attributes to Logs panel Support all display options in the Logs panel Oct 12, 2021
@Puneeth-n Puneeth-n force-pushed the chore/add-more-attributes-to-logs-panel branch 3 times, most recently from f31adae to a22fef4 Compare October 28, 2021 18:46
@Puneeth-n Puneeth-n marked this pull request as ready for review October 28, 2021 18:49
Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR looks good to me, please could you add the following to the Changelog?

x.x.x (TBD)
==================

* Added missing attributes to the Logs panel
* ...

Changes
-------

* ...

@Puneeth-n Puneeth-n force-pushed the chore/add-more-attributes-to-logs-panel branch from a22fef4 to 61c0825 Compare October 29, 2021 08:56
@JamesGibo JamesGibo merged commit 94175f4 into weaveworks:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants