Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thresholdsStyleMode parameter for TimeSeries panel #457

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Feb 16, 2022

What does this do?

Adds the ability to set thresholdsStyleMode in TimeSeries panel.
スクリーンショット 2022-02-16 15 49 25

Why is it a good idea?

Because the threshold drawing style could not be set.

Context

In the TimeSeries panel, the threshold drawing style could not be set.

Questions

@gkuga
Copy link
Contributor Author

gkuga commented Feb 17, 2022

How about removing the change log from the URL linting target since the contents easy to out of date?

Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, look good!
I will try to make a release to include it by the end of the week.

@JamesGibo JamesGibo merged commit 074d557 into weaveworks:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants