Add Azure Monitor Targets #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGibo
approved these changes
Apr 5, 2022
|
@cam-barts thanks a lot. We needed this as well. Quick question. In AzureLogsTarget, we are missing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Added support for the Azure Monitor Datasource as a target.
Why is it a good idea?
Azure monitor is heavily utilized in my corporate environment at least as a data source, and I suspect in many others as well. Because many of our services are deployed in Azure, we'd love the ability to create dashboards programatically via grafanalib. This contribution is a way for us to give back to the tool we will be heavily utilizing in the near future.
Context
The azure monitor data source exposes 3 types of data to query: Azure Monitor Metrics, Azure Logs, and Azure Resource Graph. They are all outlined on the linked document. I wrote a target and individual tests for each of those types.
Questions
I am pretty certain I'm adhering to the style guides, but my editor runs black on save so there might have been changes that that made that don't align exactly. I didn't spot anything on a cursory look, but if there is anything egregious I am happy to fix.