Added sortBy parameter to Table panel #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git-Lior
force-pushed
the
feature/table-sort
branch
from
c0fa710
to
287e4c5
Compare
JamesGibo
requested changes
Aug 18, 2023
Git-Lior
force-pushed
the
feature/table-sort
branch
from
8b30a12
to
760e415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This change allows sorting table rows by their fields
Why is it a good idea?
This is a useful feature which is supported in grafana v8:
https://grafana.com/docs/grafana/v8.0/panels/visualizations/table/#sort-column
Context
sortByin grafana's Table panel options:https://github.com/grafana/grafana/blob/v8.0.x/public/app/plugins/panel/table/models.gen.ts#L17
The name for
TableSortByFieldwas inspired by the matching type in grafana:https://github.com/grafana/grafana/blob/main/packages/grafana-ui/src/components/Table/types.ts#L24