Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

log runtime during ignite run #388

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

silenceshell
Copy link
Contributor

ignite runtime support both docker and containerd, we need to specify that in the logs.

For example, no matter I use docker runtime or containerd runtime, the log is always Docker.

# ignite --runtime docker run silenceshell/weave:docker2  --cpus 1 --memory 4GB --ssh --size 20GB --name vm-docker-2
INFO[0000] Docker image "silenceshell/weave:docker2" not found locally, pulling...
^C
# ignite --runtime containerd run silenceshell/weave:docker2  --cpus 1 --memory 4GB --ssh --size 20GB --name vm-docker-2
INFO[0000] Docker image "silenceshell/weave:docker2" not found locally, pulling...
^C
# ignite run silenceshell/weave:docker2  --cpus 1 --memory 4GB --ssh --size 20GB --name vm-docker-2
INFO[0000] Docker image "silenceshell/weave:docker2" not found locally, pulling...

Also the size checking needs a fix.

Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@luxas luxas merged commit 7d6e932 into weaveworks:master Sep 9, 2019
@silenceshell silenceshell deleted the specify-image-runtime branch September 9, 2019 14:41
@stealthybox stealthybox changed the title specify image of runtime when ignite run log runtime during ignite run Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants