This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 223
[WIP] Stabilize CNI connectivity, dns and latent #421
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to test:
|
@stealthybox PTAL |
fa3e44f
to
f0d28f2
Compare
This was referenced Sep 11, 2019
This PR needs rebase on top of #422 |
Also CNI does not have the managed DNS like Docker libnetwork, so this --dns could provide name services for VM when needed.
f0d28f2
to
5370463
Compare
Test cases implemented by #422 used to verify the behavior and all tests passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a
containerd
+CNI
behavior that users cannot connect to the internet.After investigation, I have found that there's not FORWARD rules to help the CNI bridge plugin to complete this. So I add simple rules for the Ignite network CIDR to allow forwarding.
fixes #418 #423 #424