Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

wait for SSH when starting a VM #429

Merged
merged 1 commit into from Sep 17, 2019
Merged

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Sep 15, 2019

This PR implements wait to check until the SSH service, enabled with --ssh, allows connection.
The default wait value is 10 seconds. After 10 seconds, it will return an err.

This implementation won't affect the VM without --ssh flag.

Fixes #423

Signed-off-by: Chanwit Kaewkasi chanwit@gmail.com

@chanwit chanwit added the area/networking Issues related to networking label Sep 15, 2019
@chanwit chanwit added this to the v0.6.1 milestone Sep 15, 2019
@chanwit chanwit removed the request for review from twelho September 15, 2019 12:08
@chanwit chanwit added the kind/enhancement Categorizes issue or PR as related to improving an existing feature. label Sep 16, 2019
Copy link
Contributor

@stealthybox stealthybox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

cmd/ignite/run/start.go Outdated Show resolved Hide resolved
cmd/ignite/run/start.go Outdated Show resolved Hide resolved
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@stealthybox
Copy link
Contributor

Works well -- thanks!

@stealthybox stealthybox merged commit e66ca30 into weaveworks:master Sep 17, 2019
@stealthybox stealthybox changed the title implement ssh wait for a VM wait for SSH when starting a VM Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/networking Issues related to networking kind/enhancement Categorizes issue or PR as related to improving an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CNI setup appears more latent than docker-bridge
2 participants