This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Make getIPChains more precise and less failure-prone #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
force-pushed
the
workaround-iptables
branch
from
eec6d68
to
33ed4cd
Compare
stealthybox
added
area/dependency
move fmt.Sprintf out of loop access stat.Options through rawStat[9] with hard-coded index remove break in the event there are multiple rules per containerID only parse for IPNet when we are working with the proper ignite CNI rules ^ avoids coreos/go-iptables#70
stealthybox
force-pushed
the
workaround-iptables
branch
from
33ed4cd
to
8708abf
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move fmt.Sprintf out of loop
access stat.Options through rawStat[9] with hard-coded index
remove break in the event there are multiple rules per containerID
only parse for IPNet when we are working with the proper ignite CNI rules
^ avoids coreos/go-iptables#70
Fixes #393