This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Initial set of metrics for gitops processing #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palemtnrider
force-pushed
the
gitops_metrics
branch
from
f21464c
to
f8b6212
Compare
palemtnrider
force-pushed
the
gitops_metrics
branch
from
f8b6212
to
3695ad5
Compare
|
This looks good -- I don't see anyone needing to control the metrics registrations as a dependency with the current shape of this interface, so the global vars seem appropriate. |
stealthybox
approved these changes
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put together a few simple metrics for GitOps processing. Thoughts?