Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Assign a random MAC address to the bridge #761

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Dec 23, 2020

[Did this because I was trying to use an IPVLan device and it barfs if you try to set its MAC address]

If we don't do this it will adopt the lowest address of an attached device, hence change over time. This is the issue reported at #633.

Remove the previous work-around (from #638) of getting and setting the random MAC that Linux assigned, also getting and setting the TUN address since that doesn't change if you set the bridge address.

While I was working on this, I found it useful to add context to some netlink errors.

If we don't do this it will adopt the lowest address of an attached
device, hence change over time.

Remove the previous work-around of getting and setting the random MAC
that Linux assigned, also getting and setting the TUN address since
that doesn't change if you set the bridge address.
Otherwise it just says something like 'invalid argument' and you have to guess what the problem is
@stealthybox stealthybox added area/networking Issues related to networking kind/bug Categorizes issue or PR as related to a bug. labels Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/networking Issues related to networking kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants