Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kured doesn't work with tainted nodes #95

Closed
mathieu-benoit opened this issue Nov 7, 2019 · 3 comments
Closed

kured doesn't work with tainted nodes #95

mathieu-benoit opened this issue Nov 7, 2019 · 3 comments

Comments

@mathieu-benoit
Copy link

As soon as we taint our nodes kured won't be anymore scheduled on them, this PR #88 is implementing the fix for this.

@invidian
Copy link

invidian commented Nov 7, 2019

Note: the same can be done using kured helm chart, as it has tolerations configurable: https://github.com/helm/charts/tree/master/stable/kured.

@mathieu-benoit
Copy link
Author

Oh ok good to know there is an Helm chart, thanks @invidian! Is it the recommendation moving forward to deploy kured? Are you still keeping the YAML files? Looks like maintaining both places could be redundant and confusing?

@mathieu-benoit
Copy link
Author

So to reflect that PR mentioned, I need to do this with the Helm chart:

helm install kured stable/kured \
--set tolerations[0].effect=NoSchedule \
--set tolerations[0].key=node-role.kubernetes.io/master \
--set tolerations[1].operator=Exists \
--set tolerations[1].key=CriticalAddonsOnly \
--set tolerations[2].operator=Exists \
--set tolerations[2].effect=NoExecute \
--set tolerations[3].operator=Exists \
--set tolerations[3].effect=NoSchedule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants