Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BUILD_BOT_PERSONAL_ACCESS_TOKEN instead of PAT #202

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

serboctor
Copy link
Contributor

What changed?
Use the newly added BUILD_BOT_PERSONAL_ACCESS_TOKEN instead of PAT in the github workflows.

Why was this change made?
To avoid depending on personal PATs and fix access for dependabot PRs.

How was this change implemented?
Modifying the workflows' configuration files.

How did you validate the change?
Passing checks

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #202 (6bc4c25) into dev (9d437e0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #202   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files          22       22           
  Lines        1390     1390           
=======================================
  Hits         1089     1089           
  Misses        229      229           
  Partials       72       72           
Flag Coverage Δ
unit 78.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@enekofb enekofb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but waiting to see the answer on the comment before approving

@@ -54,7 +53,7 @@ jobs:
with:
configuration: "${{ github.workspace }}/.github/workflows/changelog_configuration.json"
env:
GITHUB_TOKEN: ${{ secrets.PAT }}
GITHUB_TOKEN: ${{ secrets.BUILD_BOT_PERSONAL_ACCESS_TOKEN }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given msg ... do we need to wait for this change to happen before approving the PR ?

@enekofb enekofb self-requested a review August 15, 2023 15:40
@serboctor serboctor merged commit 15dd751 into dev Aug 15, 2023
6 checks passed
@serboctor serboctor deleted the update-workflow-secret branch August 15, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants