Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate policysets CRD #213

Closed
wants to merge 1 commit into from
Closed

Deprecate policysets CRD #213

wants to merge 1 commit into from

Conversation

Samra10
Copy link
Member

@Samra10 Samra10 commented Nov 22, 2023

Closes #209

What changed?

  • Remove policysets CR

Why was this change made?

  • to introduce a new way to define whether a policy is enforced via the admission controller or just audited for a violation.

How was this change implemented?

  • Remove Policysets CRD
  • Remove Policysets from docs
  • Remove Policysets from code

How did you validate the change?

  • Manual testing

Release notes

Documentation Changes

@Samra10 Samra10 added the enhancement New feature or request label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2a59c0) 78.34% compared to head (a05c1aa) 78.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #213      +/-   ##
==========================================
+ Coverage   78.34%   78.48%   +0.14%     
==========================================
  Files          22       22              
  Lines        1390     1390              
==========================================
+ Hits         1089     1091       +2     
+ Misses        229      226       -3     
- Partials       72       73       +1     
Flag Coverage Δ
unit 78.48% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waleedhammam
Copy link
Contributor

closing in favor of #214

@waleedhammam waleedhammam deleted the 209-deprecate-policysets branch November 26, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story] Deprecate PolicySet CRD
2 participants