Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to close the response body when reading reports from s3 #2018

Closed
paulbellamy opened this issue Nov 18, 2016 · 3 comments
Closed

Need to close the response body when reading reports from s3 #2018

paulbellamy opened this issue Nov 18, 2016 · 3 comments
Assignees
@rade
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone
1.3

Comments

@paulbellamy
Copy link
Contributor

So we don't leak memory.
@paulbellamy paulbellamy added the bug Broken end user or developer functionality; not working as the developers intended it label Nov 18, 2016
@tomwilkie
Copy link
Contributor

Good spot.

@rade
Copy link
Member

rade commented Nov 18, 2016

I guess this hasn't caused problems in practice since we always find the reports in memcache, right?

@2opremio 2opremio added this to the re:Invent milestone Nov 18, 2016
@paulbellamy
Copy link
Contributor Author

Probably yes, which doesn't return a reader.

@2opremio 2opremio modified the milestones: December2016, Next Dec 13, 2016
@rade rade modified the milestones: Next, Backlog Jan 11, 2017
@rade rade self-assigned this Apr 13, 2017
rade added a commit that referenced this issue Apr 13, 2017
@rade
close s3 response body to prevent leaks
46f288b 
Fixes #2018
@rade rade mentioned this issue Apr 13, 2017
Merged
rade added a commit that referenced this issue Apr 14, 2017
@rade
Merge pull request #2442 from weaveworks/2018-close-s3-response
76253c3 
close s3 response body to prevent leaks

Fixes #2018.
@rade rade modified the milestones: 1.3, Backlog Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rade rade

Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
1.3
Development

No branches or pull requests
4 participants
@rade @paulbellamy @tomwilkie @2opremio