Clarify terminal is child window of details panel.

[foot]

So when you close the details panel and the terminal closes too its not a surprise!

Fixes #1152

[rade]

screen cap?

[foot]

[rade]

any chance we could change the 'close' to a 'slide in'?

[rade]

and perhaps change the icon too, e.g. ">>"

[foot]

>> / slide in suggests some kind of permanence/continuity to me, as in, I'm done with this terminal session for now, lets tuck it away for later.

I like: boom, its gone, gotta make a new one now.

Though you could interpret the idea of the having access to the container as continuous thing here and it would make more sense summoning it back, thoughts? (+ @davkal)

[rade]

I see your point.

My concern is that I see the "x" button and "boom, its gone" action as indicators that the terminal has an independent life from the detail panel.

[foot]

They feel quite connected now.

There are other onClose animations we could look into but I don't wanna make it too animation heavy, and I think a snappy close is usually nice: Done here, I'm off to do something else. Vs establishing context etc as we show something new.

Alt close animation:

• Keep x
• fade out + sliding back, signifying destruction + going back home to its parent the details panel.

[davkal]

I'm happy with the immediate close on X.

Not so happy with the aesthetic. Both panels look a bit bolted together, colors are clashing a bit. There is no clear hierarchy (other than suggested by the animation). Most oddly, the details panel has a shadow, but the terminal has not.

Counter-proposal: remove the dark color border, add padding (to make it smaller to suggest hierarchy), and add shadow.

[davkal]

YES! I like the hover bit. It feels like the details panel owns the terminal. Well done. LGTM