Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prog/main: use flags.app.port for default target #2096

Merged

Conversation

schu
Copy link
Contributor

@schu schu commented Dec 16, 2016

User can control the webserver listen address with -app.http.address.
If they do, scope --mode probe ... should use the port part of address
in the default target and not ':4040'. Otherwise we encounter a
dial tcp 127.0.0.1:4040: getsockopt: connection refused error and
scope-probe cannot report.

Signed-off-by: Michael Schubert michael@kinvolk.io

User can control the webserver listen address with `-app.http.address`.
If they do, `scope --mode probe ...` should use the port part of address
in the default target and not ':4040'. Otherwise we encounter a
`dial tcp 127.0.0.1:4040: getsockopt: connection refused` error and
`scope-probe` cannot report.

Signed-off-by: Michael Schubert <michael@kinvolk.io>
@schu
Copy link
Contributor Author

schu commented Dec 16, 2016

Not perfect as the scope launcher script always prints 4040 as the listening port (https://github.com/weaveworks/scope/blob/master/scope#L178-L180), but allows you to actually use a different -app.http.address locally.

@2opremio 2opremio self-assigned this Dec 16, 2016
@2opremio
Copy link
Contributor

Thanks @schu

Not perfect as the scope launcher script always prints 4040 as the listening port (https://github.com/weaveworks/scope/blob/master/scope#L178-L180), but allows you to actually use a different -app.http.address locally.

It wasn't perfect before either (i.e. you could already listen on an different address)

@2opremio
Copy link
Contributor

Related: #1190

@2opremio 2opremio merged commit e70f2b9 into weaveworks:master Dec 16, 2016
@schu schu deleted the schu/mode-probe-port-fix branch December 19, 2016 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants