Remove replica sets #2661
Merged
Remove replica sets #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekimekim
force-pushed
the
mike/k8s/remove-replica-sets
branch
from
c9af113
to
2f1d765
Compare
|
This approach is a little hacky, but is the best we can do without changing the probe, which won't work retroactively. One other option would be changing the probe, and then doing this re-mapping to remove replica sets at |
rade
approved these changes
Jun 29, 2017
Ultimately that is the correct way to go, but only once we are sure we won't change our minds about not representing replicasets. I have raised #2662 for this. |
|
FTR, this PR is part of #2620. |
|
PS: please make the linter happy |
Use a special kind of selector renderer to elide replica sets from pod nodes and directly reference deployment parents instead. Do the inverse (replace replica sets with pods) during the mapping from pod to deployment. Note we can no longer use renderParents since we're using a non-standard Selector
ekimekim
force-pushed
the
mike/k8s/remove-replica-sets
branch
from
2f1d765
to
ef2b6f6
Compare
7 tasks
|
note: though github claims '1 of 2 test passed', it was netlify that was failing, which doesn't even test anything afaict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a special kind of selector renderer to elide replica sets from pod nodes
and directly reference deployment parents instead.
Do the inverse (replace replica sets with pods) during the mapping from pod to deployment.
Note we can no longer use renderParents since we're using a non-standard Selector