Save codegen output as CI artifact #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
save-codegen
branch
from
402f2ec
to
bf41164
Compare
Nobody is using this.
Looks like the order of types in the generated output is unpredictable, so we need the actual file Scope was built with for debugging or profiling.
|
@bboreham what's happening with this? |
|
Waiting for review? I've restarted the CI build which failed for a reason that looks unrelated |
rade
approved these changes
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the order of types in the generated output is unpredictable, so we need the actual file Scope was built with for debugging or profiling.
Also drive-by optimisation to stop saving the tarfile - we started in 441b718, which offers no explanation as to why.