-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 build #3537
Add ARM64 build #3537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One question below.
curl -fsSLO https://download.docker.com/linux/static/stable/aarch64/docker-${DOCKERVERSION}.tgz && \ | ||
tar xzvf docker-${DOCKERVERSION}.tgz --strip 1 -C /usr/local/bin docker/docker && \ | ||
rm docker-${DOCKERVERSION}.tgz; \ | ||
else \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we special-case amd64 too, so if you build on something else you get an error and you know you have to fix it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will update the PR. BTW, I had to bump the Docker client version a bit since the previous used version was not built for ARM.
backend/Dockerfile
Outdated
curl -fsSLO https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKERVERSION}.tgz && \ | ||
tar xzvf docker-${DOCKERVERSION}.tgz --strip 1 -C /usr/local/bin docker/docker && \ | ||
rm docker-${DOCKERVERSION}.tgz; \ | ||
fi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting some kind of "else error" here, otherwise the failure mode is quite obscure.
Oops, sorry. I messed up with a merge. Will fix the branch. |
Fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@bboreham Is it possible to add the ARM image build to the CI? I see you guys use Circle-CI but I'm not versed on it. I could take a look tho. Dunno if Circle have multi-arch infrastructure for this but Weave Net already builds multi-arch images and manifests. |
Sadly the status of Weave Net is I run the final release build by hand because it didn't work on CircleCI. |
It will be very helpful if ARM64 image is released as ARM64 support has already been added. May I know when are you planning to release an ARM64 image? |
Happy to review a PR. |
Actually I don't know how to add to the current PR #3372 (sorry) so I submitted this.
I can confirm that it builds and works perfectly on ARM64 in my current cluster: https://twitter.com/carlosedp/status/1073218995321483264
I'm currently building the ARM64 images and pushing them into my DockerHub account: https://hub.docker.com/r/carlosedp/scope