Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 build #3537

Merged
merged 3 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@carlosedp
Copy link
Contributor

commented Dec 18, 2018

Actually I don't know how to add to the current PR #3372 (sorry) so I submitted this.

I can confirm that it builds and works perfectly on ARM64 in my current cluster: https://twitter.com/carlosedp/status/1073218995321483264

I'm currently building the ARM64 images and pushing them into my DockerHub account: https://hub.docker.com/r/carlosedp/scope

@carlosedp carlosedp referenced this pull request Dec 18, 2018

Closed

Support ARM64 build #3372

@bboreham
Copy link
Member

left a comment

Thanks! One question below.

curl -fsSLO https://download.docker.com/linux/static/stable/aarch64/docker-${DOCKERVERSION}.tgz && \
tar xzvf docker-${DOCKERVERSION}.tgz --strip 1 -C /usr/local/bin docker/docker && \
rm docker-${DOCKERVERSION}.tgz; \
else \

This comment has been minimized.

Copy link
@bboreham

bboreham Dec 18, 2018

Member

Can we special-case amd64 too, so if you build on something else you get an error and you know you have to fix it?

This comment has been minimized.

Copy link
@carlosedp

carlosedp Dec 18, 2018

Author Contributor

Sure, will update the PR. BTW, I had to bump the Docker client version a bit since the previous used version was not built for ARM.

curl -fsSLO https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKERVERSION}.tgz && \
tar xzvf docker-${DOCKERVERSION}.tgz --strip 1 -C /usr/local/bin docker/docker && \
rm docker-${DOCKERVERSION}.tgz; \
fi;

This comment has been minimized.

Copy link
@bboreham

bboreham Jan 2, 2019

Member

I was expecting some kind of "else error" here, otherwise the failure mode is quite obscure.

@carlosedp carlosedp force-pushed the carlosedp:arm64 branch from 8345288 to 8ab29e5 Jan 2, 2019

@carlosedp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

Oops, sorry. I messed up with a merge. Will fix the branch.

@carlosedp carlosedp force-pushed the carlosedp:arm64 branch 2 times, most recently from f36612c to 2546564 Jan 2, 2019

@carlosedp carlosedp force-pushed the carlosedp:arm64 branch from 2546564 to b25f7e8 Jan 2, 2019

@carlosedp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

Fixed!

@bboreham
Copy link
Member

left a comment

Thanks!

@bboreham bboreham merged commit fdd1c26 into weaveworks:master Jan 2, 2019

6 of 8 checks passed

ci/circleci: integration-tests Your tests failed on CircleCI
Details
deploy/netlify Deploy preview failed.
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: client-build Your tests passed on CircleCI!
Details
ci/circleci: client-test Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: unit-test Your tests passed on CircleCI!
Details
ci/circleci: xplatform-build Your tests passed on CircleCI!
Details
@carlosedp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 2, 2019

@bboreham Is it possible to add the ARM image build to the CI? I see you guys use Circle-CI but I'm not versed on it. I could take a look tho. Dunno if Circle have multi-arch infrastructure for this but Weave Net already builds multi-arch images and manifests.

@bboreham

This comment has been minimized.

Copy link
Member

commented Jan 2, 2019

Sadly the status of Weave Net is I run the final release build by hand because it didn't work on CircleCI.
I think it is doable now, and should be easier for Scope, but we don't have prior art.

@bboreham bboreham referenced this pull request Feb 5, 2019

Merged

Release 1.10.2 #3567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.