Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scope working under a path #984

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Fixes scope working under a path #984

merged 1 commit into from
Feb 22, 2016

Conversation

foot
Copy link
Contributor

@foot foot commented Feb 18, 2016

  • Adds proxy server for easy testing of scope under a path.

Fixes #978

- Adds proxy server for easy testing of scope under a path.
@foot
Copy link
Contributor Author

foot commented Feb 22, 2016

Can test master is not working with this:

nginx -c /Users/blahblahahl/nginx.conf

daemon off;
http {
    server {
        listen 5000;

        location /zing/ {
        proxy_pass http://localhost:4042/;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection 'upgrade';
        proxy_set_header Host $host;
        proxy_cache_bypass $http_upgrade;
        }
    }
}


events {}

@davkal
Copy link
Contributor

davkal commented Feb 22, 2016

Solid! LGTM

foot added a commit that referenced this pull request Feb 22, 2016
@foot foot merged commit cd880a8 into master Feb 22, 2016
@foot foot deleted the 978-fix-scope-under-path branch February 22, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants