This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
Add (very short) timeout to Dial with IPv6 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connecting to a random IPv6 address will most probably not succeed, but will timeout eventually. The default timeout is too high and we don't really care about the connection succeeding or not, we just need to trigger the kprobe. This adds a timeout of 1 millisecond to the Dial function for IPv6 so each connection doesn't hang for a long time. We didn't notice this before because we haven't tried the guessing program in an IPv6 network.
iaguis
force-pushed
the
iaguis/fix-ipv6-dial
branch
from
959cdde
to
64b2693
Compare
|
Rebased. |
|
LGTM |
iaguis
added a commit
to kinvolk-archives/scope
that referenced
this pull request
Feb 4, 2017
alban
approved these changes
Feb 6, 2017
2opremio
approved these changes
Feb 7, 2017
sunhay
added a commit
to DataDog/tcptracer-bpf
that referenced
this pull request
Feb 21, 2019
…tion-to-conn-stats Add byte key to ConnectionStats to uniquely identify connections on host
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connecting to a random IPv6 address will most probably not succeed,
but will timeout eventually.
The default timeout is too high and we don't really care about the
connection succeeding or not, we just need to trigger the kprobe.
This adds a timeout of 1 millisecond to the Dial function for IPv6 so
each connection doesn't hang for a long time.
We didn't notice this before because we haven't tried the guessing
program in an IPv6 network.
Depends on #1